[llvm] [NewGVN][1/3] Load coercion between load and store (PR #68659)

Arthur Eubanks via llvm-commits llvm-commits at lists.llvm.org
Tue Oct 24 15:38:37 PDT 2023


================
@@ -3021,6 +3184,17 @@ std::pair<unsigned, unsigned> NewGVN::assignDFSNumbers(BasicBlock *B,
   return std::make_pair(Start, End);
 }
 
+unsigned NewGVN::updateDFSNumbers(unsigned ICount) {
----------------
aeubanks wrote:

I'd make the param `unsigned &ICount` so that callers can't forget to reassign the return value to `ICount`, then for the call site where you pass in `0`, set `ICount` to `0` instead and pass that in

https://github.com/llvm/llvm-project/pull/68659


More information about the llvm-commits mailing list