[llvm] [CVP] Flip signedness icmp predicate in use level (PR #69948)
via llvm-commits
llvm-commits at lists.llvm.org
Tue Oct 24 03:56:00 PDT 2023
https://github.com/XChy updated https://github.com/llvm/llvm-project/pull/69948
>From befcd3883f7da47597a79e0b91267344aedce38c Mon Sep 17 00:00:00 2001
From: XChy <xxs_chy at outlook.com>
Date: Tue, 24 Oct 2023 01:18:33 +0800
Subject: [PATCH 1/2] [CVP][NFC] Precommit for flipping signedness predicate in
use level
---
.../CorrelatedValuePropagation/icmp.ll | 105 ++++++++++++++++++
1 file changed, 105 insertions(+)
diff --git a/llvm/test/Transforms/CorrelatedValuePropagation/icmp.ll b/llvm/test/Transforms/CorrelatedValuePropagation/icmp.ll
index c4f0ade39942a76..b039506f4584b3d 100644
--- a/llvm/test/Transforms/CorrelatedValuePropagation/icmp.ll
+++ b/llvm/test/Transforms/CorrelatedValuePropagation/icmp.ll
@@ -1246,3 +1246,108 @@ declare <2 x i8> @llvm.umin.v2i8(<2 x i8>, <2 x i8>)
declare <2 x i8> @llvm.umax.v2i8(<2 x i8>, <2 x i8>)
attributes #4 = { noreturn }
+
+define i1 @pr69928(i64 noundef %arg, i64 noundef %arg1) {
+; CHECK-LABEL: @pr69928(
+; CHECK-NEXT: entry:
+; CHECK-NEXT: [[CMP1:%.*]] = icmp ult i64 [[ARG:%.*]], 64424509440
+; CHECK-NEXT: [[AND:%.*]] = and i64 [[ARG1:%.*]], 4294967295
+; CHECK-NEXT: [[CMP2:%.*]] = icmp slt i64 [[ARG]], [[AND]]
+; CHECK-NEXT: [[SELECT:%.*]] = select i1 [[CMP1]], i1 [[CMP2]], i1 false
+; CHECK-NEXT: ret i1 [[SELECT]]
+;
+entry:
+ %cmp1 = icmp ult i64 %arg, 64424509440
+ %and = and i64 %arg1, 4294967295
+ %cmp2 = icmp slt i64 %arg, %and
+ %select = select i1 %cmp1, i1 %cmp2, i1 false
+ ret i1 %select
+}
+
+define i1 @test_select_flip(i64 noundef %arg) {
+; CHECK-LABEL: @test_select_flip(
+; CHECK-NEXT: entry:
+; CHECK-NEXT: [[CMP1:%.*]] = icmp ult i64 [[ARG:%.*]], 1000
+; CHECK-NEXT: [[CMP2:%.*]] = icmp slt i64 [[ARG]], 100
+; CHECK-NEXT: [[SELECT:%.*]] = select i1 [[CMP1]], i1 [[CMP2]], i1 false
+; CHECK-NEXT: ret i1 [[SELECT]]
+;
+entry:
+ %cmp1 = icmp ult i64 %arg, 1000
+ %cmp2 = icmp slt i64 %arg, 100
+ %select = select i1 %cmp1, i1 %cmp2, i1 false
+ ret i1 %select
+}
+
+define i1 @test_select_flip_fail1(i64 noundef %arg) {
+; CHECK-LABEL: @test_select_flip_fail1(
+; CHECK-NEXT: entry:
+; CHECK-NEXT: [[CMP1:%.*]] = icmp slt i64 [[ARG:%.*]], 1000
+; CHECK-NEXT: [[CMP2:%.*]] = icmp slt i64 [[ARG]], 100
+; CHECK-NEXT: [[SELECT:%.*]] = select i1 [[CMP1]], i1 [[CMP2]], i1 false
+; CHECK-NEXT: ret i1 [[SELECT]]
+;
+entry:
+ %cmp1 = icmp slt i64 %arg, 1000
+ %cmp2 = icmp slt i64 %arg, 100
+ %select = select i1 %cmp1, i1 %cmp2, i1 false
+ ret i1 %select
+}
+
+define i1 @test_select_flip_fail2(i64 noundef %arg) {
+; CHECK-LABEL: @test_select_flip_fail2(
+; CHECK-NEXT: entry:
+; CHECK-NEXT: [[CMP1:%.*]] = icmp ult i64 [[ARG:%.*]], 1000
+; CHECK-NEXT: [[CMP2:%.*]] = icmp slt i64 [[ARG]], 100
+; CHECK-NEXT: [[SELECT:%.*]] = select i1 [[CMP1]], i1 false, i1 [[CMP2]]
+; CHECK-NEXT: ret i1 [[SELECT]]
+;
+entry:
+ %cmp1 = icmp ult i64 %arg, 1000
+ %cmp2 = icmp slt i64 %arg, 100
+ %select = select i1 %cmp1, i1 false, i1 %cmp2
+ ret i1 %select
+}
+
+define i1 @test_select_flip_fail3(i64 noundef %arg, i64 noundef %arg1) {
+; CHECK-LABEL: @test_select_flip_fail3(
+; CHECK-NEXT: entry:
+; CHECK-NEXT: [[CMP1:%.*]] = icmp ult i64 [[ARG1:%.*]], 1000
+; CHECK-NEXT: [[CMP2:%.*]] = icmp slt i64 [[ARG:%.*]], 100
+; CHECK-NEXT: [[SELECT:%.*]] = select i1 [[CMP1]], i1 [[CMP2]], i1 false
+; CHECK-NEXT: ret i1 [[SELECT]]
+;
+entry:
+ %cmp1 = icmp ult i64 %arg1, 1000
+ %cmp2 = icmp slt i64 %arg, 100
+ %select = select i1 %cmp1, i1 %cmp2, i1 false
+ ret i1 %select
+}
+
+define i1 @test_select_flip_fail4(i64 noundef %arg) {
+; CHECK-LABEL: @test_select_flip_fail4(
+; CHECK-NEXT: entry:
+; CHECK-NEXT: [[CMP2:%.*]] = icmp slt i64 [[ARG:%.*]], 100
+; CHECK-NEXT: [[SELECT:%.*]] = select i1 true, i1 [[CMP2]], i1 false
+; CHECK-NEXT: ret i1 [[SELECT]]
+;
+entry:
+ %cmp2 = icmp slt i64 %arg, 100
+ %select = select i1 true, i1 %cmp2, i1 false
+ ret i1 %select
+}
+
+define i1 @test_select_flip_fail5(i64 noundef %arg, i64 noundef %arg1) {
+; CHECK-LABEL: @test_select_flip_fail5(
+; CHECK-NEXT: entry:
+; CHECK-NEXT: [[CMP1:%.*]] = icmp ult i64 [[ARG:%.*]], 1000
+; CHECK-NEXT: [[CMP2:%.*]] = icmp slt i64 [[ARG]], [[ARG1:%.*]]
+; CHECK-NEXT: [[SELECT:%.*]] = select i1 [[CMP1]], i1 [[CMP2]], i1 false
+; CHECK-NEXT: ret i1 [[SELECT]]
+;
+entry:
+ %cmp1 = icmp ult i64 %arg, 1000
+ %cmp2 = icmp slt i64 %arg, %arg1
+ %select = select i1 %cmp1, i1 %cmp2, i1 false
+ ret i1 %select
+}
>From 89f8ce7033f1011f8e178827d24dd78a50e9e712 Mon Sep 17 00:00:00 2001
From: XChy <xxs_chy at outlook.com>
Date: Tue, 24 Oct 2023 01:09:33 +0800
Subject: [PATCH 2/2] [CVP] Flip signedness icmp predicate in use level
---
llvm/lib/Transforms/Scalar/CorrelatedValuePropagation.cpp | 5 +++--
llvm/test/Transforms/CorrelatedValuePropagation/icmp.ll | 4 ++--
2 files changed, 5 insertions(+), 4 deletions(-)
diff --git a/llvm/lib/Transforms/Scalar/CorrelatedValuePropagation.cpp b/llvm/lib/Transforms/Scalar/CorrelatedValuePropagation.cpp
index 523196e5e6eab71..9043c434313fedc 100644
--- a/llvm/lib/Transforms/Scalar/CorrelatedValuePropagation.cpp
+++ b/llvm/lib/Transforms/Scalar/CorrelatedValuePropagation.cpp
@@ -294,8 +294,9 @@ static bool processICmp(ICmpInst *Cmp, LazyValueInfo *LVI) {
ICmpInst::Predicate UnsignedPred =
ConstantRange::getEquivalentPredWithFlippedSignedness(
- Cmp->getPredicate(), LVI->getConstantRange(Cmp->getOperand(0), Cmp),
- LVI->getConstantRange(Cmp->getOperand(1), Cmp));
+ Cmp->getPredicate(),
+ LVI->getConstantRangeAtUse(Cmp->getOperandUse(0)),
+ LVI->getConstantRangeAtUse(Cmp->getOperandUse(1)));
if (UnsignedPred == ICmpInst::Predicate::BAD_ICMP_PREDICATE)
return false;
diff --git a/llvm/test/Transforms/CorrelatedValuePropagation/icmp.ll b/llvm/test/Transforms/CorrelatedValuePropagation/icmp.ll
index b039506f4584b3d..6770bcea2876764 100644
--- a/llvm/test/Transforms/CorrelatedValuePropagation/icmp.ll
+++ b/llvm/test/Transforms/CorrelatedValuePropagation/icmp.ll
@@ -1252,7 +1252,7 @@ define i1 @pr69928(i64 noundef %arg, i64 noundef %arg1) {
; CHECK-NEXT: entry:
; CHECK-NEXT: [[CMP1:%.*]] = icmp ult i64 [[ARG:%.*]], 64424509440
; CHECK-NEXT: [[AND:%.*]] = and i64 [[ARG1:%.*]], 4294967295
-; CHECK-NEXT: [[CMP2:%.*]] = icmp slt i64 [[ARG]], [[AND]]
+; CHECK-NEXT: [[CMP2:%.*]] = icmp ult i64 [[ARG]], [[AND]]
; CHECK-NEXT: [[SELECT:%.*]] = select i1 [[CMP1]], i1 [[CMP2]], i1 false
; CHECK-NEXT: ret i1 [[SELECT]]
;
@@ -1268,7 +1268,7 @@ define i1 @test_select_flip(i64 noundef %arg) {
; CHECK-LABEL: @test_select_flip(
; CHECK-NEXT: entry:
; CHECK-NEXT: [[CMP1:%.*]] = icmp ult i64 [[ARG:%.*]], 1000
-; CHECK-NEXT: [[CMP2:%.*]] = icmp slt i64 [[ARG]], 100
+; CHECK-NEXT: [[CMP2:%.*]] = icmp ult i64 [[ARG]], 100
; CHECK-NEXT: [[SELECT:%.*]] = select i1 [[CMP1]], i1 [[CMP2]], i1 false
; CHECK-NEXT: ret i1 [[SELECT]]
;
More information about the llvm-commits
mailing list