[llvm] [InstCombine] enable more factorization in SimplifyUsingDistributiveLaws (PR #69892)
Nikita Popov via llvm-commits
llvm-commits at lists.llvm.org
Tue Oct 24 01:43:42 PDT 2023
https://github.com/nikic commented:
Just to get the obvious stuff out of the way:
* Please update the patch description to describe what this patch is doing.
* Add alive2 proofs.
* It looks like you are adding two related but independent transforms here -- I would recommend splitting them into separate patches.
* And yes, we should not hardcode mul opcodes -- if we do, there should be clear justification for doing that.
https://github.com/llvm/llvm-project/pull/69892
More information about the llvm-commits
mailing list