[llvm] [CVP] Flip signedness icmp predicate in use level (PR #69948)

Nikita Popov via llvm-commits llvm-commits at lists.llvm.org
Mon Oct 23 11:08:35 PDT 2023


https://github.com/nikic commented:

The change looks good to me, but can you please adjust the test coverage so the second condition is not implied (i.e. folds to true) by the first? In that case the transform isn't really meaningful.

As you mark https://github.com/llvm/llvm-project/issues/69928 as fixed, you should also add the test case from there.

https://github.com/llvm/llvm-project/pull/69948


More information about the llvm-commits mailing list