[llvm] [LLVM][DWARF] Change to consistently print out abbrev code. (PR #68353)

Alexander Yermolovich via llvm-commits llvm-commits at lists.llvm.org
Fri Oct 6 12:16:23 PDT 2023


ayermolo wrote:

> Could you explain a bit more (maybe a simple example/comparison in the commit description would also be helpful) the motivation for this consistency? They look like they're printing out similarly enough already to be filecheck'd, etc?

Ah right. Difference comes in when letters are involved in hex: upper case vs lower case.
As can be seen in llvm/test/tools/llvm-dwarfdump/X86/debug-names-misaligned.s in the commit.

Which then makes the FileCheck pattern matching fail.
[[ABBREV1:0x[0-9a-f]*]]
[[ABBREV1]]

Will update commit description.

https://github.com/llvm/llvm-project/pull/68353


More information about the llvm-commits mailing list