[PATCH] D151848: [X86, Peephole] Enable FoldImmediate for X86

Thu Oct 5 15:23:22 PDT 2023

MatzeB added inline comments.

================
Comment at: llvm/lib/Target/X86/X86InstrInfo.cpp:4873
+      break;
+  }
+  return NewOpcode;
----------------
MatzeB wrote:
> MatzeB wrote:
> > When inspecting something like `grep "32ri\s*=" build/lib/Target/X86/X86GenInstrInfo.inc` or `grep "64rr\s*=" build/lib/Target/X86/X86GenInstrInfo.inc` I noticed a couple more that probably work?
> > * ADC32rr / ADC32ri  (also ADD64rr)
> > * ROL32rCL / ROL32ri
> > * ROR32rCL / ROR32ri
> > * RCL32rCL / RCL32ri
> > * RCR32rCL / RCR32ri
> > * SBB32rr / SBB32ri  (also SBB64rr)
> > * TEST32rr / TEST32ri  (also TEST64rr)
> * CMP32rr / CMP32ri
heh, just realized I didn't push "submit" on this so you didn't see it on my last review...

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D151848/new/

https://reviews.llvm.org/D151848