[llvm] [LLVM][DWARF] Add support for monolithic types in .debug_names (PR #68131)

[David Blaikie via llvm-commits]

================
@@ -3514,11 +3520,15 @@ void DwarfDebug::addDwarfTypeUnitType(DwarfCompileUnit &CU,
       return;
     }
 
-    // If the type wasn't dependent on fission addresses, finish adding the type
-    // and all its dependent types.
     for (auto &TU : TypeUnitsToAdd) {
       InfoHolder.computeSizeAndOffsetsForUnit(TU.first.get());
       InfoHolder.emitUnit(TU.first.get(), useSplitDwarf());
+      if (getDwarfVersion() >= 5 &&
+          getAccelTableKind() == AccelTableKind::Dwarf) {
+        addTypeUnit(std::move(TU.first));
----------------
dwblaikie wrote:

It wouldn't be, no - type units have overhead necessary to make them standalone units, so the overhead is higher (& in any case, even if it isn't higher - it's still a lost opportunity/regression to substantially increase the memory overhead when using type units)

https://github.com/llvm/llvm-project/pull/68131