[llvm] [BOLT] Support instrumentation hook via DT_FINI_ARRAY (PR #67348)

Vladislav Khmelevsky via llvm-commits llvm-commits at lists.llvm.org
Thu Oct 5 09:58:30 PDT 2023


yota9 wrote:

> > I mean that tests in runtime folder are going to be executed. So ideally we would like the non-runtime test without binary execution to check the functionality. It is true that currently we're not supporting cross-compilation for runtime binary, that is why for non-runtime tests we have extra arch requirement. But we have this task in our backlog, so hopefully it would be changed and we would be able to run these tests too.
> 
> Just to be sure: you also don't see another way to test this so we keep the current test?

We can keep the current test I guess, but it would be better to add non-runtime.. Since currently it relies on the binary successfully exit - no, I don't. The non-runtime test should be easy to do, but it is just monotonic job, although the filecheck prefixes would be repeated across the multiple tests, so I guess it won't be too hard to find the needed symbol and check relocation(s) against it..

https://github.com/llvm/llvm-project/pull/67348


More information about the llvm-commits mailing list