[llvm] [AArch64][SME] Add remarks to flag lazy ZA saves, and SMSTART/SMSTOP transitions (PR #68255)

Sander de Smalen via llvm-commits llvm-commits at lists.llvm.org
Thu Oct 5 00:25:36 PDT 2023


================
@@ -7362,6 +7363,18 @@ AArch64TargetLowering::LowerCall(CallLoweringInfo &CLI,
   else if (auto *ES = dyn_cast<ExternalSymbolSDNode>(CLI.Callee))
     CalleeAttrs = SMEAttrs(ES->getSymbol());
 
+  auto DescribeCallsite =
+      [&](OptimizationRemarkAnalysis &R) -> OptimizationRemarkAnalysis & {
----------------
sdesmalen-arm wrote:

nit: Would it be easier to have a function that takes just a StringRef, so that you can do `EmitSMERemarkForCall("requires a streaming mode transition");`? You can then hide the construction of the ORE and OptimizationRemarkAnalysis in this lambda.

https://github.com/llvm/llvm-project/pull/68255


More information about the llvm-commits mailing list