[llvm] [JITLink] Allow multiple relocations at same offset in EHFrameEdgeFixer (PR #68252)

Jonas Hahnfeld via llvm-commits llvm-commits at lists.llvm.org
Wed Oct 4 23:33:04 PDT 2023


hahnjo wrote:

> Would disabling the assertion that there's a single edge in the EH-frame fixer fix the issue for now?

Of course, that is what https://reviews.llvm.org/D157802 originally proposed to do almost two months ago.

> As a temporary fix I prefer commenting out the assertion. We could land this too, but I suspect we'll want to revert in the future and move to a design where edges support more than one target instead. I _think_ we're gong to want to be able to say "what is _the edge_ at this offset", then inspect the result, rather than parsing a sequence of edges at an offset to understand what's going on. We really need a proper discussion about this though.

And I personally don't like committing "temporary fixes" aka hacks. During the discussion, it became clear to me that https://reviews.llvm.org/D157802 is nothing more than a hack because the code relies on finding a uniquely identified target and the code should really check that this is possible. How would this work if a) there are multiple edges at that offset, or b) in the future there are edges with multiple targets?

https://github.com/llvm/llvm-project/pull/68252


More information about the llvm-commits mailing list