[compiler-rt] [scudo] Fix the use of ASSERT_CAPABILITY in TSD (PR #68273)

via llvm-commits llvm-commits at lists.llvm.org
Wed Oct 4 16:49:47 PDT 2023


github-actions[bot] wrote:


<!--LLVM CODE FORMAT COMMENT: {clang-format}-->

:warning: C/C++ code formatter, clang-format found issues in your code. :warning:

<details>
<summary>
You can test this locally with the following command:
</summary>

``````````bash
git-clang-format --diff 6e9ee42a5161081dcada4c2d187eb8e1bbff633a e2090b340f49c3fe382fe9c26afcf7ba21b4abe2 -- compiler-rt/lib/scudo/standalone/combined.h compiler-rt/lib/scudo/standalone/tests/combined_test.cpp compiler-rt/lib/scudo/standalone/tests/tsd_test.cpp compiler-rt/lib/scudo/standalone/tsd.h compiler-rt/lib/scudo/standalone/tsd_shared.h
``````````

</details>

<details>
<summary>
View the diff from clang-format here.
</summary>

``````````diff
diff --git a/compiler-rt/lib/scudo/standalone/tsd.h b/compiler-rt/lib/scudo/standalone/tsd.h
index 5eb1bc0cc07e..b2108a01900b 100644
--- a/compiler-rt/lib/scudo/standalone/tsd.h
+++ b/compiler-rt/lib/scudo/standalone/tsd.h
@@ -53,9 +53,7 @@ template <class Allocator> struct alignas(SCUDO_CACHE_LINE_SIZE) TSD {
   inline void unlock() NO_THREAD_SAFETY_ANALYSIS { Mutex.unlock(); }
   inline uptr getPrecedence() { return atomic_load_relaxed(&Precedence); }
 
-  void commitBack(Allocator *Instance) {
-    Instance->commitBack(this);
-  }
+  void commitBack(Allocator *Instance) { Instance->commitBack(this); }
 
   // As the comments attached to `getCache()`, the TSD doesn't always need to be
   // locked. In that case, we would only skip the check before we have all TSDs
@@ -74,9 +72,7 @@ template <class Allocator> struct alignas(SCUDO_CACHE_LINE_SIZE) TSD {
   // TODO(chiahungduan): Ideally, we want to do `Mutex.assertHeld` but acquiring
   // TSD doesn't always require holding the lock. Add this assertion while the
   // lock is always acquired.
-  typename Allocator::CacheT &getCache() REQUIRES(Mutex) {
-    return Cache;
-  }
+  typename Allocator::CacheT &getCache() REQUIRES(Mutex) { return Cache; }
   typename Allocator::QuarantineCacheT &getQuarantineCache() REQUIRES(Mutex) {
     return QuarantineCache;
   }

``````````

</details>


https://github.com/llvm/llvm-project/pull/68273


More information about the llvm-commits mailing list