[llvm] [AArch64][SME] Add remarks to flag lazy ZA saves, and SMSTART/SMSTOP transitions (PR #68255)

via llvm-commits llvm-commits at lists.llvm.org
Wed Oct 4 13:32:30 PDT 2023


github-actions[bot] wrote:


<!--LLVM CODE FORMAT COMMENT: {clang-format}-->

:warning: C/C++ code formatter, clang-format found issues in your code. :warning:

<details>
<summary>
You can test this locally with the following command:
</summary>

``````````bash
git-clang-format --diff b7ac16c70faf7274119f393797ce89c054346f48 10471605becbff1ad98664648b3f5d6fd211a05b -- llvm/lib/Target/AArch64/AArch64ISelLowering.cpp
``````````

</details>

<details>
<summary>
View the diff from clang-format here.
</summary>

``````````diff
diff --git a/llvm/lib/Target/AArch64/AArch64ISelLowering.cpp b/llvm/lib/Target/AArch64/AArch64ISelLowering.cpp
index 7c474e3c610c..726e6bcef9a5 100644
--- a/llvm/lib/Target/AArch64/AArch64ISelLowering.cpp
+++ b/llvm/lib/Target/AArch64/AArch64ISelLowering.cpp
@@ -7363,11 +7363,9 @@ AArch64TargetLowering::LowerCall(CallLoweringInfo &CLI,
   else if (auto *ES = dyn_cast<ExternalSymbolSDNode>(CLI.Callee))
     CalleeAttrs = SMEAttrs(ES->getSymbol());
 
-  auto DescribeCallsite = [&](OptimizationRemarkAnalysis &R)
-      -> OptimizationRemarkAnalysis & {
-    R << "call from "
-      << ore::NV("Caller", MF.getName())
-      << " to ";
+  auto DescribeCallsite =
+      [&](OptimizationRemarkAnalysis &R) -> OptimizationRemarkAnalysis & {
+    R << "call from " << ore::NV("Caller", MF.getName()) << " to ";
     if (auto *ES = dyn_cast<ExternalSymbolSDNode>(CLI.Callee))
       R << ore::NV("Callee", ES->getSymbol());
     else if (CLI.CB && CLI.CB->getCalledFunction())
@@ -7404,12 +7402,12 @@ AArch64TargetLowering::LowerCall(CallLoweringInfo &CLI,
         DAG.getConstant(Intrinsic::aarch64_sme_set_tpidr2, DL, MVT::i32),
         TPIDR2ObjAddr);
     OptimizationRemarkEmitter ORE(&MF.getFunction());
-    ORE.emit([&](){
-      auto R = CLI.CB
-          ? OptimizationRemarkAnalysis(DEBUG_TYPE, "SMELazySaveZA", CLI.CB)
-          : OptimizationRemarkAnalysis(DEBUG_TYPE, "SMELazySaveZA", &MF.getFunction());
-      DescribeCallsite(R)
-        << " creates a lazy save ZA area";
+    ORE.emit([&]() {
+      auto R = CLI.CB ? OptimizationRemarkAnalysis(DEBUG_TYPE, "SMELazySaveZA",
+                                                   CLI.CB)
+                      : OptimizationRemarkAnalysis(DEBUG_TYPE, "SMELazySaveZA",
+                                                   &MF.getFunction());
+      DescribeCallsite(R) << " creates a lazy save ZA area";
       return R;
     });
   }
@@ -7420,12 +7418,12 @@ AArch64TargetLowering::LowerCall(CallLoweringInfo &CLI,
   if (RequiresSMChange) {
     PStateSM = getPStateSM(DAG, Chain, CallerAttrs, DL, MVT::i64);
     OptimizationRemarkEmitter ORE(&MF.getFunction());
-    ORE.emit([&](){
-      auto R = CLI.CB
-          ? OptimizationRemarkAnalysis(DEBUG_TYPE, "SMETransition", CLI.CB)
-          : OptimizationRemarkAnalysis(DEBUG_TYPE, "SMETransition", &MF.getFunction());
-      DescribeCallsite(R)
-        << " requires a streaming mode transition";
+    ORE.emit([&]() {
+      auto R = CLI.CB ? OptimizationRemarkAnalysis(DEBUG_TYPE, "SMETransition",
+                                                   CLI.CB)
+                      : OptimizationRemarkAnalysis(DEBUG_TYPE, "SMETransition",
+                                                   &MF.getFunction());
+      DescribeCallsite(R) << " requires a streaming mode transition";
       return R;
     });
   }

``````````

</details>


https://github.com/llvm/llvm-project/pull/68255


More information about the llvm-commits mailing list