[PATCH] D157802: [JITLink][EHFrameSupport] Accept multiple relocations

Wed Oct 4 13:17:07 PDT 2023

Hahnfeld abandoned this revision.
Hahnfeld added a comment.

In D157802#4648649 <https://reviews.llvm.org/D157802#4648649>, @jobnoorman wrote:

> In D157802#4648392 <https://reviews.llvm.org/D157802#4648392>, @Hahnfeld wrote:
>
>> Ah ok, I see. Then we still have one shot left to make that idea work, by only looking at relocations on offsets that need processing by `EHFrameEdgeFixer`. That would still require the `Offset32` approach because we need the keep-alive edges.
>
> The keep-alive edges are added while processing the PC-begin field for which RISC-V uses `R_RISCV_32_PCREL` so I don't think we have to do anything special here.
>
>> Or we just teach `EHFrameEdgeFixer` to handle multiple relocations at one offset, which gets a bit tricky which one to use for getting the correct target...
>
> I also don't think this is strictly necessary since all the `ADD`/`SUB` relocs are already there and don't need fixing up. It seems to be enough to just not err on them.

Yes, you are absolutely right. I posted an implementation in a PR on GitHub: https://github.com/llvm/llvm-project/pull/68252

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D157802/new/

https://reviews.llvm.org/D157802