[compiler-rt] [IRPGO][ValueProfile] Instrument virtual table address that could be used to do virtual table address comparision for indirect-call-promotion. (PR #66825)
Mingming Liu via llvm-commits
llvm-commits at lists.llvm.org
Tue Oct 3 23:18:00 PDT 2023
================
@@ -519,13 +591,20 @@ class InstrProfSymtab {
/// will be represented using the same StringRef value.
inline StringRef getFuncNameOrExternalSymbol(uint64_t FuncMD5Hash);
+ /// Just like getFuncName, except that it will return a non-empty StringRef
----------------
minglotus-6 wrote:
Cleaned this up.
I just realized `getFuncNameOrExternalSymbol` and `getFuncName` (line 587) needs a rename. These two functions are used in many places (llvm-profdata, text profile writer, coverage mapping, and unit test). I'm going to send out an NFC for the rename.
https://github.com/llvm/llvm-project/pull/66825
More information about the llvm-commits
mailing list