[llvm] Fix #65890: Update the bot message to use github pull requests (PR #65914)

via llvm-commits llvm-commits at lists.llvm.org
Tue Oct 3 12:25:55 PDT 2023


https://github.com/Da-Viper updated https://github.com/llvm/llvm-project/pull/65914

>From 9c17bb1ead6e8433ba0cebfe264ebb133c59ee81 Mon Sep 17 00:00:00 2001
From: Ezike Ebuka <yerimyah1 at gmail.com>
Date: Sun, 10 Sep 2023 22:39:18 +0100
Subject: [PATCH 1/3] Fix #65890: Update the bot message to use github pull
 requests

---
 llvm/utils/git/github-automation.py | 8 +++-----
 1 file changed, 3 insertions(+), 5 deletions(-)

diff --git a/llvm/utils/git/github-automation.py b/llvm/utils/git/github-automation.py
index 7df20ea8457155b..77f1b1f2aab24e9 100755
--- a/llvm/utils/git/github-automation.py
+++ b/llvm/utils/git/github-automation.py
@@ -23,17 +23,15 @@
 
 This issue may be a good introductory issue for people new to working on LLVM. If you would like to work on this issue, your first steps are:
 
-  1) Assign the issue to you.
+  1) In the comments of the issue, request for it to be assigned to you.
   2) Fix the issue locally.
   3) [Run the test suite](https://llvm.org/docs/TestingGuide.html#unit-and-regression-tests) locally.
     3.1) Remember that the subdirectories under `test/` create fine-grained testing targets, so you can
          e.g. use `make check-clang-ast` to only run Clang's AST tests.
   4) Create a `git` commit
   5) Run [`git clang-format HEAD~1`](https://clang.llvm.org/docs/ClangFormat.html#git-integration) to format your changes.
-  6) Submit the patch to [Phabricator](https://reviews.llvm.org/).
-    6.1) Detailed instructions can be found [here](https://llvm.org/docs/Phabricator.html#requesting-a-review-via-the-web-interface)
-
-For more instructions on how to submit a patch to LLVM, see our [documentation](https://llvm.org/docs/Contributing.html).
+  6) Submit the pull request in the [github repository](https://github.com/llvm/llvm-project/pulls).
+    6.1) Detailed instructions can be found [here](https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/proposing-changes-to-your-work-with-pull-requests/creating-a-pull-request)
 
 If you have any further questions about this issue, don't hesitate to ask via a comment on this Github issue.
 """

>From 661b44881e87221656387c45f4f8608652ac9c5d Mon Sep 17 00:00:00 2001
From: Da-Viper <57949090+Da-Viper at users.noreply.github.com>
Date: Tue, 3 Oct 2023 20:25:41 +0100
Subject: [PATCH 2/3] Update llvm/utils/git/github-automation.py
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Co-authored-by: Danny Mösch <danny.moesch at icloud.com>
---
 llvm/utils/git/github-automation.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/llvm/utils/git/github-automation.py b/llvm/utils/git/github-automation.py
index 77f1b1f2aab24e9..a50f01c118525aa 100755
--- a/llvm/utils/git/github-automation.py
+++ b/llvm/utils/git/github-automation.py
@@ -30,7 +30,7 @@
          e.g. use `make check-clang-ast` to only run Clang's AST tests.
   4) Create a `git` commit
   5) Run [`git clang-format HEAD~1`](https://clang.llvm.org/docs/ClangFormat.html#git-integration) to format your changes.
-  6) Submit the pull request in the [github repository](https://github.com/llvm/llvm-project/pulls).
+  6) Open a pull request to the [upstream repository](https://github.com/llvm/llvm-project/pulls) on GitHub.
     6.1) Detailed instructions can be found [here](https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/proposing-changes-to-your-work-with-pull-requests/creating-a-pull-request)
 
 If you have any further questions about this issue, don't hesitate to ask via a comment on this Github issue.

>From b7e0d86f5f01dcea86ffc8e84cb9d6e4cecb0c8e Mon Sep 17 00:00:00 2001
From: Da-Viper <57949090+Da-Viper at users.noreply.github.com>
Date: Tue, 3 Oct 2023 20:25:49 +0100
Subject: [PATCH 3/3] Update llvm/utils/git/github-automation.py
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Co-authored-by: Danny Mösch <danny.moesch at icloud.com>
---
 llvm/utils/git/github-automation.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/llvm/utils/git/github-automation.py b/llvm/utils/git/github-automation.py
index a50f01c118525aa..1bb68dd4f14af0c 100755
--- a/llvm/utils/git/github-automation.py
+++ b/llvm/utils/git/github-automation.py
@@ -31,7 +31,7 @@
   4) Create a `git` commit
   5) Run [`git clang-format HEAD~1`](https://clang.llvm.org/docs/ClangFormat.html#git-integration) to format your changes.
   6) Open a pull request to the [upstream repository](https://github.com/llvm/llvm-project/pulls) on GitHub.
-    6.1) Detailed instructions can be found [here](https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/proposing-changes-to-your-work-with-pull-requests/creating-a-pull-request)
+    6.1) Detailed instructions can be found [here](https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/proposing-changes-to-your-work-with-pull-requests/creating-a-pull-request).
 
 If you have any further questions about this issue, don't hesitate to ask via a comment on this Github issue.
 """



More information about the llvm-commits mailing list