[PATCH] D152205: [Aarch64][SVE]SVE2] Enable tbl, tbl2 for shuffle lowering for fixed vector types.
Sander de Smalen via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Oct 3 05:05:48 PDT 2023
sdesmalen accepted this revision.
sdesmalen added a comment.
This revision is now accepted and ready to land.
LGTM, thanks!
================
Comment at: llvm/lib/Target/AArch64/AArch64ISelLowering.cpp:25854
+ // Handling poison index value.
+ if (Index == -1)
+ Index = 0;
----------------
nit: I don't know if this can ever happen, but maybe it's more safe to write `if (Index < 0)` if any other values can be used to represent `poison`.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D152205/new/
https://reviews.llvm.org/D152205
More information about the llvm-commits
mailing list