[PATCH] D153990: [DebugInfo][RemoveDIs] Add prototype storage classes for non-instruction variable debug-info

[Orlando Cazalet-Hyams via Phabricator via llvm-commits]

Orlando added a comment.

LGTM once inline comments have been addressed



================
Comment at: llvm/unittests/IR/DebugInfoTest.cpp:732
+  DPValue *DPV1 = nullptr;
+  {
+  DbgValueInst *DPI = dyn_cast<DbgValueInst>(&I);
----------------
clang-format


================
Comment at: llvm/unittests/IR/DebugInfoTest.cpp:777-780
+  FirstInst->DbgMarker = new DPMarker();
+  FirstInst->DbgMarker->MarkedInstr = FirstInst;
+  RetInst->DbgMarker = new DPMarker();
+  RetInst->DbgMarker->MarkedInstr = RetInst;
----------------
Is there an API for handling this behind the scenes by adding DPValues to instructions? If not, why not, if yes, please can we test that too?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D153990/new/

https://reviews.llvm.org/D153990