[llvm] [BOLT] Support instrumentation hook via DT_FINI_ARRAY (PR #67348)

Vladislav Khmelevsky via llvm-commits llvm-commits at lists.llvm.org
Mon Oct 2 03:38:37 PDT 2023


================
@@ -1276,6 +1280,57 @@ void RewriteInstance::discoverFileObjects() {
   registerFragments();
 }
 
+Error RewriteInstance::discoverFiniAddress() {
----------------
yota9 wrote:

But this one doesn't overwrite it, it's only returns if the binary has DT_FINI or DT_FINI_ARRAY. Theoretically, of course, it might be used by something else, although I doubt to be honest. Also the mirror rewriting function "updateFiniReloc" is clearly runtime-specific due to getRuntimeLibrary call. Since these are 2 in pair for single purpose my humble opinion is that their place is in runtime-specific code..

https://github.com/llvm/llvm-project/pull/67348


More information about the llvm-commits mailing list