[llvm] Add myself to CODEOWNERS (PR #66363)

Nikita Popov via llvm-commits llvm-commits at lists.llvm.org
Mon Oct 2 02:01:48 PDT 2023


https://github.com/nikic updated https://github.com/llvm/llvm-project/pull/66363

>From c766c70e36f7752ce17b14b3df8f53737b4f5c0e Mon Sep 17 00:00:00 2001
From: Nikita Popov <npopov at redhat.com>
Date: Thu, 14 Sep 2023 12:10:24 +0200
Subject: [PATCH 1/3] Add myself to CODEOWNERS

---
 .github/CODEOWNERS | 10 ++++++++++
 1 file changed, 10 insertions(+)

diff --git a/.github/CODEOWNERS b/.github/CODEOWNERS
index ded7d9df068e0dd..4f30b55c84e289e 100644
--- a/.github/CODEOWNERS
+++ b/.github/CODEOWNERS
@@ -2,3 +2,13 @@
 /libcxxabi/ @llvm/reviewers-libcxxabi
 /libunwind/ @llvm/reviewers-libunwind
 /runtimes/ @llvm/reviewers-libcxx
+
+/llvm/lib/Analysis/BasicAliasAnalysis.cpp @nikic
+/llvm/lib/Analysis/InstructionSimplify.cpp @nikic
+/llvm/lib/Analysis/LazyValueInfo.cpp @nikic
+/llvm/lib/Analysis/ScalarEvolution.cpp @nikic
+/llvm/lib/Analysis/ValueTracking.cpp @nikic
+/llvm/lib/IR/ConstantRange.cpp @nikic
+/llvm/lib/Transforms/Scalar/CorrelatedValuePropagation.cpp @nikic
+/llvm/lib/Transforms/Scalar/MemCpyOptimizer.cpp @nikic
+/llvm/lib/Transforms/InstCombine/ @nikic

>From 298d2754a06bc867fbb435eb71957fa6f94d6ccf Mon Sep 17 00:00:00 2001
From: Nikita Popov <npopov at redhat.com>
Date: Fri, 22 Sep 2023 16:04:28 +0200
Subject: [PATCH 2/3] Add explanatory comment

---
 .github/CODEOWNERS | 13 +++++++++++++
 1 file changed, 13 insertions(+)

diff --git a/.github/CODEOWNERS b/.github/CODEOWNERS
index 4f30b55c84e289e..b4a0df96d5a9a09 100644
--- a/.github/CODEOWNERS
+++ b/.github/CODEOWNERS
@@ -1,3 +1,16 @@
+# This file lists reviewers that are auto-assigned when a pull request modifies
+# certain files or directories. If you add yourself to this file, you commit to
+# reviewing a large fraction of pull requests in the relevant area.
+#
+# The GitHub "code owners" mechanism is used exclusively to auto-assign
+# reviewers and does not carry significance beyond that. It is not necessary
+# to receive an approval from a "code owner" in particular -- any LLVM project
+# member can approve pull requests.
+#
+# Note that GitHub's concept of "code owner" is independent from LLVM's own
+# "code owner" concept, they merely happen to share terminology. See the
+# CODE_OWNERS.txt files in the respective subproject directories.
+
 /libcxx/ @llvm/reviewers-libcxx
 /libcxxabi/ @llvm/reviewers-libcxxabi
 /libunwind/ @llvm/reviewers-libunwind

>From 5b034fa429db6aa28b15096f4327d1e221332cd8 Mon Sep 17 00:00:00 2001
From: Nikita Popov <npopov at redhat.com>
Date: Mon, 2 Oct 2023 11:01:12 +0200
Subject: [PATCH 3/3] Link to code owners section in developer policy

---
 .github/CODEOWNERS | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/.github/CODEOWNERS b/.github/CODEOWNERS
index b4a0df96d5a9a09..209a74428aa76d5 100644
--- a/.github/CODEOWNERS
+++ b/.github/CODEOWNERS
@@ -8,7 +8,8 @@
 # member can approve pull requests.
 #
 # Note that GitHub's concept of "code owner" is independent from LLVM's own
-# "code owner" concept, they merely happen to share terminology. See the
+# "code owner" concept, they merely happen to share terminology. See
+# https://llvm.org/docs/DeveloperPolicy.html#code-owners, as well as the
 # CODE_OWNERS.txt files in the respective subproject directories.
 
 /libcxx/ @llvm/reviewers-libcxx



More information about the llvm-commits mailing list