[PATCH] D155431: [CMake] Clean up old code for handling MSVC runtime setting the old way

[Yury Bura via Phabricator via llvm-commits]

yurybura added a comment.

> Are you saying that this gets added automatically by CMake in this variable, or that it is set manually by your build configuration? I don't think it's added automatically by CMake.

I'm saying that VCPKG adds these compiler flags. I use this package manager to build LLVM projects, including `compiler-rt`. Starting from LLVM 17.0.1 I see the build error.

> The point is that by switching `CMAKE_MSVC_RUNTIME_LIBRARY` to the right choice, debug/non-debug, the define `_DEBUG` gets added automatically by the compiler if building in a debug mode. You shouldn't be adding that manually.

As I understand `_DEBUG` is not added by default. How to add it for Debug config for the whole LLVM/Clang build but exclude adding it to `compiler-rt` or `libcxx`?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D155431/new/

https://reviews.llvm.org/D155431