[PATCH] D155431: [CMake] Clean up old code for handling MSVC runtime setting the old way

Thu Sep 28 06:18:44 PDT 2023

mstorsjo added a comment.

In D155431#4651674 <https://reviews.llvm.org/D155431#4651674>, @mstorsjo wrote:

> In D155431#4651673 <https://reviews.llvm.org/D155431#4651673>, @yurybura wrote:
>
>> Once again, the default value for CMAKE_MSVC_RUNTIME_LIBRARY is `MultiThreaded$<$<CONFIG:Debug>:Debug>DLL` for the entire LLVM build, `/D_DEBUG` is added to CMAKE_CXX_FLAGS_DEBUG.
>
> Are you saying that this gets added automatically by CMake in this variable, or that it is set manually by your build configuration? I don't think it's added automatically by CMake.

I just tested building a CMake project, setting `CMAKE_BUILD_TYPE=Debug`, not touching `CMAKE_MSVC_RUNTIME_LIBRARY`. CMake invokes `cl.exe` with `/MDd`, `/D_DEBUG` is never passed explicit to the compiler - this is implied by `/MDd`.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D155431/new/

https://reviews.llvm.org/D155431