[PATCH] D159368: [RISCV] Remove SEW operand for load/store and SEW-aware pseudos

[Wang Pengcheng via Phabricator via llvm-commits]

wangpc added a comment.

In D159368#4650924 <https://reviews.llvm.org/D159368#4650924>, @michaelmaitland wrote:

> In D159368#4650810 <https://reviews.llvm.org/D159368#4650810>, @wangpc wrote:
>
>> Ping.
>> Do we agree to do this?
>
> I think so. My last comment expresses that there may be some lost opportunity since less instructions `hasSEWOp` now. The diff in this patch shows that we bail out of some optimizations when `!hasSEWOp`. I am concerned that the SEW operand we remove from the instructions in this patch may lead to bailing out early, when we still have SEW information. I think we could be doing `hasSEWOp() || hasSEWInPseudoName()` to guard these optimizations and add something like `getSEWFromPseudoName()`. WDYT?

IIRC, I think I have done the `hasSEWOp() || hasSEWInPseudoName()` thing in newly-added `RISCVII::hasSEW`?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D159368/new/

https://reviews.llvm.org/D159368