[PATCH] D159368: [RISCV] Remove SEW operand for load/store and SEW-aware pseudos
Michael Maitland via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Sep 26 07:02:21 PDT 2023
michaelmaitland added a comment.
In D159368#4650810 <https://reviews.llvm.org/D159368#4650810>, @wangpc wrote:
> Ping.
> Do we agree to do this?
I think so. My last comment expresses that there may be some lost opportunity since less instructions `hasSEWOp` now. The diff in this patch shows that we bail out of some optimizations when `!hasSEWOp`. I am concerned that the SEW operand we remove from the instructions in this patch may lead to bailing out early, when we still have SEW information. I think we could be doing `hasSEWOp() || hasSEWInPseudoName()` to guard these optimizations and add something like `getSEWFromPseudoName()`. WDYT?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D159368/new/
https://reviews.llvm.org/D159368
More information about the llvm-commits
mailing list