[PATCH] D159543: [BOLT] Fix .relr section addend patching

[Maksim Panchenko via Phabricator via llvm-commits]

maksfb added a comment.

The alignment change looks good to me (with a nit). The answer to my second question lies in the way we attach a label to a constant island. For. a pure CI, i.e. the one not attached to a function, it's the function label that defines the island. Even though the island will have another `FunctionConstantIslandLabel`, similar to regular CIs attached to a function, this label will not be used.

Can you commit this fix separately since it's not directly related to .relr patching?



================
Comment at: bolt/lib/Passes/Aligner.cpp:165
+      uint16_t Alignment = BF.getConstantIslandAlignment();
+      // Check if we're forcing output alignment and it is greater then minimal
+      // CI required one
----------------



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D159543/new/

https://reviews.llvm.org/D159543