[PATCH] D157716: [lld-macho] Postprocess LC Linker Option

[Kyungwoo Lee via Phabricator via llvm-commits]

kyulee added inline comments.


================
Comment at: lld/MachO/Driver.cpp:524
+        StringRef name = LCLinkerOptions[++i];
+        if (config->ignoreAutoLinkOptions.contains(name))
+          continue;
----------------
thakis wrote:
> We have this `contains` check both here and in `parseLCLinkerOption()`. Do we need it in both places? Shouldn't just `parseLCLinkerOption()` be enough?
Thanks for catching this. I think it's left out while I'm refactoring the code.
I make a pull request -- https://github.com/llvm/llvm-project/pull/67450


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D157716/new/

https://reviews.llvm.org/D157716