[PATCH] D157716: [lld-macho] Postprocess LC Linker Option

Nico Weber via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Sep 26 07:26:22 PDT 2023


thakis added inline comments.


================
Comment at: lld/MachO/Driver.cpp:524
+        StringRef name = LCLinkerOptions[++i];
+        if (config->ignoreAutoLinkOptions.contains(name))
+          continue;
----------------
We have this `contains` check both here and in `parseLCLinkerOption()`. Do we need it in both places? Shouldn't just `parseLCLinkerOption()` be enough?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D157716/new/

https://reviews.llvm.org/D157716



More information about the llvm-commits mailing list