[llvm] [NVPTX] Optimize v16i8 reductions (PR #67322)

Artem Belevich via llvm-commits llvm-commits at lists.llvm.org
Mon Sep 25 13:30:04 PDT 2023


================
@@ -5294,6 +5295,98 @@ static SDValue PerformEXTRACTCombine(SDNode *N,
   return Result;
 }
 
+static SDValue PerformLOADCombine(SDNode *N,
+                                  TargetLowering::DAGCombinerInfo &DCI) {
+  SelectionDAG &DAG = DCI.DAG;
+  LoadSDNode *LD = cast<LoadSDNode>(N);
+
+  // Lower a v16i8 load into a LoadV4 operation with i32 results instead of
+  // letting ReplaceLoadVector split it into smaller loads during legalization.
+  // This is done at dag-combine1 time, so that vector operations with i8
+  // elements can be optimised away instead of being needlessly split during
+  // legalization, which involves storing to the stack and loading it back.
+  EVT VT = N->getValueType(0);
+  if (VT != MVT::v16i8)
+    return SDValue();
+
+  SDLoc DL(N);
+
+  // Create a v4i32 vector load operation, effectively <4 x v4i8>.
+  unsigned Opc = NVPTXISD::LoadV4;
+  EVT NewVT = MVT::v4i32;
+  EVT EleVT = NewVT.getVectorElementType();
----------------
Artem-B wrote:

Naming nit. Usually `Element` gets shortened to `Elt` in other places in this file. IMO `Elt` is a bit easier to read. At least it automatically expands back to `Element` when I read it, while I keep stumbling on on the `e` in `EleVT` -- "how do I say it? E-le-vee-tee? ".

https://github.com/llvm/llvm-project/pull/67322


More information about the llvm-commits mailing list