[PATCH] D156444: [llvm][RISCV][IR] Zext flag in IR for RISC-V

[Nikita Popov via Phabricator via llvm-commits]

nikic added a comment.

The semantics need to be a change to llvm/docs/LangRef.rst in this patch, not a comment.

As I said before, I don't think it makes sense to add nneg support to zext constant expressions, which are slated for removal.



================
Comment at: llvm/include/llvm/IR/Operator.h:349
+public:
+  ///
+  bool hasNonNeg() const { return (SubclassOptionalData & NonNeg) != 0; }
----------------
Missing comment text?


================
Comment at: llvm/lib/Bitcode/Writer/BitcodeWriter.cpp:105
 /// These are manifest constants used by the bitcode writer. They do not need to
-/// be kept in sync with the reader, but need to be consistent within this file.
+/// // TODO add zext be kept in sync with the reader, but need to be consistent
+/// within this file.
----------------
craig.topper wrote:
> This TODO is in the middle of a sentence
Not done?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D156444/new/

https://reviews.llvm.org/D156444