[llvm] 0944eea - [NFC][ObjectSizeOffsetVisitor] Remove redundant equality check

Arthur Eubanks via llvm-commits llvm-commits at lists.llvm.org
Fri Sep 22 13:15:53 PDT 2023


Author: Arthur Eubanks
Date: 2023-09-22T13:15:22-07:00
New Revision: 0944eea8232c55ce59b1d52ce66e0fb957ec3760

URL: https://github.com/llvm/llvm-project/commit/0944eea8232c55ce59b1d52ce66e0fb957ec3760
DIFF: https://github.com/llvm/llvm-project/commit/0944eea8232c55ce59b1d52ce66e0fb957ec3760.diff

LOG: [NFC][ObjectSizeOffsetVisitor] Remove redundant equality check

Originally suggested in https://reviews.llvm.org/D131001 but I accidentally took only have of the suggestion.

Added: 
    

Modified: 
    llvm/lib/Analysis/MemoryBuiltins.cpp

Removed: 
    


################################################################################
diff  --git a/llvm/lib/Analysis/MemoryBuiltins.cpp b/llvm/lib/Analysis/MemoryBuiltins.cpp
index ced6a43916b5b64..9eab801c3ccbb97 100644
--- a/llvm/lib/Analysis/MemoryBuiltins.cpp
+++ b/llvm/lib/Analysis/MemoryBuiltins.cpp
@@ -988,7 +988,7 @@ SizeOffsetType ObjectSizeOffsetVisitor::combineSizeOffset(SizeOffsetType LHS,
     return (getSizeWithOverflow(LHS).eq(getSizeWithOverflow(RHS))) ? LHS
                                                                    : unknown();
   case ObjectSizeOpts::Mode::ExactUnderlyingSizeAndOffset:
-    return LHS == RHS && LHS.second.eq(RHS.second) ? LHS : unknown();
+    return LHS == RHS ? LHS : unknown();
   }
   llvm_unreachable("missing an eval mode");
 }


        


More information about the llvm-commits mailing list