[llvm] [TargetLowering] remove unused virtual from ComputeConstraintToUse (PR #67171)
via llvm-commits
llvm-commits at lists.llvm.org
Fri Sep 22 11:08:03 PDT 2023
llvmbot wrote:
<!--LLVM PR SUMMARY COMMENT-->
@llvm/pr-subscribers-llvm-analysis
<details>
<summary>Changes</summary>
There are no overrides in tree.
Fix up resulting linkage failures in unittests and sort the dependency
lists.
---
Full diff: https://github.com/llvm/llvm-project/pull/67171.diff
3 Files Affected:
- (modified) llvm/include/llvm/CodeGen/TargetLowering.h (+2-3)
- (modified) llvm/unittests/Analysis/CMakeLists.txt (+2-1)
- (modified) llvm/unittests/Passes/Plugins/CMakeLists.txt (+1-1)
``````````diff
diff --git a/llvm/include/llvm/CodeGen/TargetLowering.h b/llvm/include/llvm/CodeGen/TargetLowering.h
index c46d78e460b3250..0b4222ba2feb707 100644
--- a/llvm/include/llvm/CodeGen/TargetLowering.h
+++ b/llvm/include/llvm/CodeGen/TargetLowering.h
@@ -4836,9 +4836,8 @@ class TargetLowering : public TargetLoweringBase {
/// AsmOperandInfo, setting OpInfo.ConstraintCode and OpInfo.ConstraintType.
/// If the actual operand being passed in is available, it can be passed in as
/// Op, otherwise an empty SDValue can be passed.
- virtual void ComputeConstraintToUse(AsmOperandInfo &OpInfo,
- SDValue Op,
- SelectionDAG *DAG = nullptr) const;
+ void ComputeConstraintToUse(AsmOperandInfo &OpInfo, SDValue Op,
+ SelectionDAG *DAG = nullptr) const;
/// Given a constraint, return the type of constraint it is for this target.
virtual ConstraintType getConstraintType(StringRef Constraint) const;
diff --git a/llvm/unittests/Analysis/CMakeLists.txt b/llvm/unittests/Analysis/CMakeLists.txt
index 847430bf17697ab..6e5bb703dacf188 100644
--- a/llvm/unittests/Analysis/CMakeLists.txt
+++ b/llvm/unittests/Analysis/CMakeLists.txt
@@ -2,11 +2,12 @@ set(LLVM_LINK_COMPONENTS
Analysis
AsmParser
Core
+ IPO
Passes
+ SelectionDAG
Support
TargetParser
TransformUtils
- IPO
)
set(ANALYSIS_TEST_SOURCES
diff --git a/llvm/unittests/Passes/Plugins/CMakeLists.txt b/llvm/unittests/Passes/Plugins/CMakeLists.txt
index e90cae167bc2223..986ce1a55bf4f5d 100644
--- a/llvm/unittests/Passes/Plugins/CMakeLists.txt
+++ b/llvm/unittests/Passes/Plugins/CMakeLists.txt
@@ -3,7 +3,7 @@
# work with DLLs on Windows (where a shared library can't have undefined
# references), so just skip this testcase on Windows.
if (NOT WIN32 AND NOT CYGWIN)
- set(LLVM_LINK_COMPONENTS Support Passes Core AsmParser)
+ set(LLVM_LINK_COMPONENTS Support Passes Core AsmParser SelectionDAG)
add_llvm_unittest(PluginsTests
PluginsTest.cpp
)
``````````
</details>
https://github.com/llvm/llvm-project/pull/67171
More information about the llvm-commits
mailing list