[llvm] [RFC][GlobalISel] Use Builders in MatchTable (PR #65955)

via llvm-commits llvm-commits at lists.llvm.org
Fri Sep 22 04:33:22 PDT 2023


github-actions[bot] wrote:


<!--LLVM CODE FORMAT COMMENT: {clang-format}-->

:warning: C/C++ code formatter, clang-format found issues in your code. :warning:

<details>
<summary>
You can test this locally with the following command:
</summary>

``````````bash
git-clang-format --diff fe7fe6d3437da98017b93c99737e421c35e52b7b 06e1fb6ea742d86c50ce410a235893df09e07f48 -- llvm/include/llvm/CodeGen/GlobalISel/GIMatchTableExecutor.h llvm/include/llvm/CodeGen/GlobalISel/GIMatchTableExecutorImpl.h llvm/utils/TableGen/GlobalISelCombinerEmitter.cpp llvm/utils/TableGen/GlobalISelEmitter.cpp
``````````

</details>

<details>
<summary>
View the diff from clang-format here.
</summary>

``````````diff
diff --git a/llvm/include/llvm/CodeGen/GlobalISel/GIMatchTableExecutorImpl.h b/llvm/include/llvm/CodeGen/GlobalISel/GIMatchTableExecutorImpl.h
index 1a0a0f46cc73..6f0f9a6a46c7 100644
--- a/llvm/include/llvm/CodeGen/GlobalISel/GIMatchTableExecutorImpl.h
+++ b/llvm/include/llvm/CodeGen/GlobalISel/GIMatchTableExecutorImpl.h
@@ -52,12 +52,11 @@ bool GIMatchTableExecutor::executeMatchTable(
     const PredicateBitset &AvailableFeatures,
     CodeGenCoverage *CoverageInfo) const {
 
-
   uint64_t CurrentIdx = 0;
   SmallVector<uint64_t, 4> OnFailResumeAt;
   NewMIVector OutMIs;
 
-  GISelChangeObserver* Observer = Builder.getObserver();
+  GISelChangeObserver *Observer = Builder.getObserver();
   // Bypass the flag check on the instruction, and only look at the MCInstrDesc.
   bool NoFPException = !State.MIs[0]->getDesc().mayRaiseFPException();
 
@@ -907,13 +906,12 @@ bool GIMatchTableExecutor::executeMatchTable(
       if (NewInsnID >= OutMIs.size())
         OutMIs.resize(NewInsnID + 1);
 
-      MachineInstr* OldMI = State.MIs[OldInsnID];
-      if(Observer)
+      MachineInstr *OldMI = State.MIs[OldInsnID];
+      if (Observer)
         Observer->changingInstr(*OldMI);
-      OutMIs[NewInsnID] = MachineInstrBuilder(*OldMI->getMF(),
-                                              OldMI);
+      OutMIs[NewInsnID] = MachineInstrBuilder(*OldMI->getMF(), OldMI);
       OutMIs[NewInsnID]->setDesc(TII.get(NewOpcode));
-      if(Observer)
+      if (Observer)
         Observer->changedInstr(*OldMI);
       DEBUG_WITH_TYPE(TgtExecutor::getName(),
                       dbgs() << CurrentIdx << ": GIR_MutateOpcode(OutMIs["
@@ -1256,7 +1254,7 @@ bool GIMatchTableExecutor::executeMatchTable(
       // pointer in the builder.
       if (Builder.getInsertPt() == MI)
         Builder.setInsertPt(*MI->getParent(), ++MI->getIterator());
-      if(Observer)
+      if (Observer)
         Observer->erasingInstr(*MI);
       MI->eraseFromParent();
       break;

``````````

</details>


https://github.com/llvm/llvm-project/pull/65955


More information about the llvm-commits mailing list