[compiler-rt] a15fbf0 - [NFC][hwasan] Remove redundant constant

Vitaly Buka via llvm-commits llvm-commits at lists.llvm.org
Thu Sep 21 21:10:58 PDT 2023


Author: Vitaly Buka
Date: 2023-09-21T21:10:44-07:00
New Revision: a15fbf05529550c35f1b8bf4a4e98f070ce99c02

URL: https://github.com/llvm/llvm-project/commit/a15fbf05529550c35f1b8bf4a4e98f070ce99c02
DIFF: https://github.com/llvm/llvm-project/commit/a15fbf05529550c35f1b8bf4a4e98f070ce99c02.diff

LOG: [NFC][hwasan] Remove redundant constant

Added: 
    

Modified: 
    compiler-rt/lib/hwasan/hwasan_report.cpp

Removed: 
    


################################################################################
diff  --git a/compiler-rt/lib/hwasan/hwasan_report.cpp b/compiler-rt/lib/hwasan/hwasan_report.cpp
index 0590e231448c04d..5e8aa315801bcdf 100644
--- a/compiler-rt/lib/hwasan/hwasan_report.cpp
+++ b/compiler-rt/lib/hwasan/hwasan_report.cpp
@@ -342,14 +342,13 @@ template <typename PrintTag>
 static void PrintTagInfoAroundAddr(uptr addr, uptr num_rows,
                                    InternalScopedString &s,
                                    PrintTag print_tag) {
-  const uptr row_len = 16;  // better be power of two.
-  uptr center_row_beg = RoundDownTo(addr, row_len);
-  uptr beg_row = center_row_beg - row_len * (num_rows / 2);
-  uptr end_row = center_row_beg + row_len * ((num_rows + 1) / 2);
-  for (uptr row = beg_row; row < end_row; row += row_len) {
+  uptr center_row_beg = RoundDownTo(addr, kDumpWidth);
+  uptr beg_row = center_row_beg - kDumpWidth * (num_rows / 2);
+  uptr end_row = center_row_beg + kDumpWidth * ((num_rows + 1) / 2);
+  for (uptr row = beg_row; row < end_row; row += kDumpWidth) {
     s.Append(row == center_row_beg ? "=>" : "  ");
     s.AppendF("%p:", (void *)ShadowToMem(row));
-    for (uptr i = 0; i < row_len; i++) {
+    for (uptr i = 0; i < kDumpWidth; i++) {
       s.Append(row + i == addr ? "[" : " ");
       print_tag(s, row + i);
       s.Append(row + i == addr ? "]" : " ");


        


More information about the llvm-commits mailing list