[llvm] [TargetLowering] Deduplicate choosing InlineAsm constraint between ISels (PR #67057)

Nick Desaulniers via llvm-commits llvm-commits at lists.llvm.org
Thu Sep 21 14:29:46 PDT 2023


================
@@ -468,13 +468,11 @@ class SITargetLowering final : public AMDGPUTargetLowering {
   getRegForInlineAsmConstraint(const TargetRegisterInfo *TRI,
                                StringRef Constraint, MVT VT) const override;
   ConstraintType getConstraintType(StringRef Constraint) const override;
-  void LowerAsmOperandForConstraint(SDValue Op,
-                                    std::string &Constraint,
+  void LowerAsmOperandForConstraint(SDValue Op, const StringRef Constraint,
----------------
nickdesaulniers wrote:

oh, I was sloppy, how is that not a compile time failure...will remove all const

https://github.com/llvm/llvm-project/pull/67057


More information about the llvm-commits mailing list