[llvm] [RISCV][SelectionDAG] Sign extend splats of i32 in getConstant on RV64 (PR #67027)

Craig Topper via llvm-commits llvm-commits at lists.llvm.org
Thu Sep 21 11:46:58 PDT 2023


topperc wrote:

> This seems reasonable, but I'd like a second opinion from someone more knowledgeable. Maybe @topperc?

I'm not opposed to this patch.

The other thought I have would be to add all of the vector .vx pseudoinstructions to hasAllNBitUsers in RISCVISelDAGToDAG.cpp. When we do constant materialization we call that to see if the upper bits of the immediate are used.

https://github.com/llvm/llvm-project/pull/67027


More information about the llvm-commits mailing list