[llvm] [RISCV] Fix wrong implication for zvknhb. (PR #66860)
Craig Topper via llvm-commits
llvm-commits at lists.llvm.org
Wed Sep 20 18:45:03 PDT 2023
================
@@ -599,15 +599,21 @@ def HasStdExtZvkned : Predicate<"Subtarget->hasStdExtZvkned()">,
def FeatureStdExtZvknha
: SubtargetFeature<"experimental-zvknha", "HasStdExtZvknha", "true",
"'Zvknha' (Vector SHA-2 (SHA-256 only))">;
-
-def FeatureStdExtZvknhb
- : SubtargetFeature<"experimental-zvknhb", "HasStdExtZvknhb", "true",
- "'Zvknhb' (Vector SHA-2 (SHA-256 and SHA-512))",
- [FeatureStdExtZvknha]>;
def HasStdExtZvknha : Predicate<"Subtarget->hasStdExtZvknha()">,
AssemblerPredicate<(all_of FeatureStdExtZvknha),
"'Zvknha' (Vector SHA-2 (SHA-256 only))">;
+def FeatureStdExtZvknhb
+ : SubtargetFeature<"experimental-zvknhb", "HasStdExtZvknhb", "true",
+ "'Zvknhb' (Vector SHA-2 (SHA-256 and SHA-512))">;
----------------
topperc wrote:
I think "requires" might mean "implies". This keeps happening with different extensions. Here's one example https://github.com/riscv/riscv-v-spec/issues/723#issuecomment-922153867
https://github.com/llvm/llvm-project/pull/66860
More information about the llvm-commits
mailing list