[PATCH] D150079: [BPF][DebugInfo] Show CO-RE relocations in llvm-objdump

Eduard Zingerman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Sep 20 16:50:13 PDT 2023


eddyz87 added a comment.

Hi @MaskRay, @jhenderson,

Thank you for all the feedback!
I've applied the latest suggestions and going to merge this revision once CI is done.

> Link to https://docs.kernel.org/bpf/llvm_reloc.html ?

Commit message updated, thank you for the `--verbatim` tip.



================
Comment at: llvm/lib/DebugInfo/BTF/BTFParser.cpp:539
+
+struct StrOrAnon {
+  const BTFParser &BTF;
----------------
MaskRay wrote:
> `namespace { ... }` per https://llvm.org/docs/CodingStandards.html#anonymous-namespaces
Forgot about namespaces here, sorry. Surprisingly, to avoid compilation errors `operator<<` had to be moved inside the namespace as well.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D150079/new/

https://reviews.llvm.org/D150079



More information about the llvm-commits mailing list