[PATCH] D152840: [ELF] A new code layout algorithm for function reordering [3a/3]

Wed Sep 20 15:51:18 PDT 2023

MaskRay added a comment.

In D152840#4648633 <https://reviews.llvm.org/D152840#4648633>, @spupyrev wrote:

> In D152840#4648582 <https://reviews.llvm.org/D152840#4648582>, @MaskRay wrote:
>
>> In D152840#4648483 <https://reviews.llvm.org/D152840#4648483>, @spupyrev wrote:
>>
>>> In D152840#4648482 <https://reviews.llvm.org/D152840#4648482>, @MaskRay wrote:
>>>
>>>> Thanks for the update. I am mainly waiting for the renamed function (`applyCDSort` does not convey the meaning well), changes of nested std::pair and `std::vector` => `SmallVector<*, 0>`
>>>
>>> I have an impression the changes are made in the follow-up D159526 <https://reviews.llvm.org/D159526> (which I'd prefer to land after this one). Do I miss something?
>>
>> You are right. You may rebase this patch on top of D159526 <https://reviews.llvm.org/D159526> :)
>
> I suggest to rebase D159526 <https://reviews.llvm.org/D159526> on top of this one

D159526 <https://reviews.llvm.org/D159526> performed the rename. If this patch is applied, `applyCDSort` in lld/ELF  will need to be updated again. This is exactly the scenario I want to avoid.
D159527 <https://reviews.llvm.org/D159527> added a unittest, which I consider necessary for making more application of the new layout algorithm.
(lld/test/ELF is not supposed to test functional change in llvm/)

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D152840/new/

https://reviews.llvm.org/D152840