[llvm] [BOLT][RISCV] Carry-over annotations when fixing calls (PR #66763)

Amir Ayupov via llvm-commits llvm-commits at lists.llvm.org
Wed Sep 20 11:05:59 PDT 2023


================
@@ -39,8 +41,19 @@ void FixRISCVCallsPass::runOnFunction(BinaryFunction &BF) {
         auto *Target = MIB->getTargetSymbol(*II);
         assert(Target && "Cannot find call target");
 
+        auto OldCall = *NextII;
----------------
aaupov wrote:

Yes, we should stick to LLVM policy of only using auto in small number of cases (the type is obvious (casts), the type doesn't matter (lambdas), template type). Making type explicit helps with reviewing where we have limited context window by default. 

https://github.com/llvm/llvm-project/pull/66763


More information about the llvm-commits mailing list