[PATCH] D153014: Deduplication of cyclic PHI nodes

[Anna Thomas via Phabricator via llvm-commits]

anna added a comment.

Looks like the missing concern from Nikita is about the compile time impact. Marek is checking this using the compile time tracker.



================
Comment at: llvm/lib/Transforms/Utils/Local.cpp:1342
+      unsigned Result = 0;
+      for (int i = 0, e = PN->getNumIncomingValues(); i != e; ++i) {
+        auto *Incoming = PN->getIncomingValue(i);
----------------
Pls add a comment on why a custom hash is used.  


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D153014/new/

https://reviews.llvm.org/D153014