[PATCH] D158291: [PoC][WIP] Add an AArch64 specific pass for loop idiom recognition

[Craig Topper via Phabricator via llvm-commits]

craig.topper added inline comments.


================
Comment at: llvm/lib/Target/AArch64/AArch64LoopIdiomRecognize.cpp:515
+  Value *SVELhsGep = Builder.CreateGEP(LoadType, PtrA, GepOffset);
+  cast<GetElementPtrInst>(SVELhsGep)->setIsInBounds(true);
+  Value *SVELhsLoad = Builder.CreateMaskedLoad(SVELoadType, SVELhsGep, Align(1),
----------------
Do we need to check for inBounds on the original GEPs before we can set it here?


================
Comment at: llvm/lib/Target/AArch64/AArch64LoopIdiomRecognize.cpp:520
+  Value *SVERhsGep = Builder.CreateGEP(LoadType, PtrB, GepOffset);
+  cast<GetElementPtrInst>(SVERhsGep)->setIsInBounds(true);
+  Value *SVERhsLoad = Builder.CreateMaskedLoad(SVELoadType, SVERhsGep, Align(1),
----------------
Do we need to check for inBounds on the original GEPs before we can set it here?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D158291/new/

https://reviews.llvm.org/D158291