[llvm] Fix the logic in DWARFContext thread safety selection (#11) (PR #66786)

Greg Clayton via llvm-commits llvm-commits at lists.llvm.org
Tue Sep 19 10:35:46 PDT 2023


================
@@ -734,7 +734,7 @@ DWARFContext::DWARFContext(std::unique_ptr<const DWARFObject> DObj,
     : DIContext(CK_DWARF),
       RecoverableErrorHandler(RecoverableErrorHandler),
       WarningHandler(WarningHandler), DObj(std::move(DObj)) {
-        if (ThreadSafe)
+        if (!ThreadSafe)
           State.reset(new ThreadUnsafeDWARFContextState(*this, DWPName));
         else
           State.reset(new ThreadSafeState(*this, DWPName));
----------------
clayborg wrote:

It would be nice to just invert this if contents:
```
if (ThreadSafe)
  State.reset(new ThreadSafeState(*this, DWPName));
else
  State.reset(new ThreadUnsafeDWARFContextState(*this, DWPName));
```


https://github.com/llvm/llvm-project/pull/66786


More information about the llvm-commits mailing list