[llvm] [BOLT][RISCV] Carry-over annotations when fixing calls (PR #66763)

Vladislav Khmelevsky via llvm-commits llvm-commits at lists.llvm.org
Tue Sep 19 06:33:40 PDT 2023


================
@@ -39,8 +41,19 @@ void FixRISCVCallsPass::runOnFunction(BinaryFunction &BF) {
         auto *Target = MIB->getTargetSymbol(*II);
         assert(Target && "Cannot find call target");
 
+        auto OldCall = *NextII;
----------------
yota9 wrote:

Let the Meta team members to clarify, they even has patches for auto expansion and asked me couple years ago. Maybe the policy changed. At least the LLVM coding standard says:
>> Don’t “almost always” use auto, but do use auto with initializers like cast<Foo>(...) or other places where the type is already obvious from the context. 
E.g. here it is obviously MCInst or MCSymbol above & etc. I don't really insist, but as for me I don't really like autos too except for complex types with smth like returning std::vector with std::pair elements.. 

https://github.com/llvm/llvm-project/pull/66763


More information about the llvm-commits mailing list