[PATCH] D155711: [SimplifyCFG] Hoist common instructions on Switch.

DianQK via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Sep 19 06:01:05 PDT 2023


DianQK added a comment.

In D155711#4647910 <https://reviews.llvm.org/D155711#4647910>, @nikic wrote:

> This looks fine to me, but I think this is currently missing tests for the "hoist not first instruction" case for switch? We should have at least basic tests that this is supported and side effects are checked.

Thanks. I added the switch variant to `hoist-common-skip.ll`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D155711/new/

https://reviews.llvm.org/D155711



More information about the llvm-commits mailing list