[PATCH] D156087: [MLIR] Add stage to side effect

Tue Sep 19 05:06:40 PDT 2023

cxy-1993 added a comment.

In D156087#4647473 <https://reviews.llvm.org/D156087#4647473>, @ftynse wrote:

> DIdn't the forum RFC conclude on using the `parameters` attribute for this instead of adding new fields?

Sorry for not inform you and updating the RFC in a timely manner. During our discussions with animi, we concluded that it would be more appropriate to use a new domain to represent the stages at which side effects occur, rather than directly using the attribute. As a result, I have replaced the usage of the parameter with two new domains: "stage" and "effectOnFullRegion." You can refer to the comments above for the discussion details.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D156087/new/

https://reviews.llvm.org/D156087