[llvm] [NFC][Bitcode] Remove unused param in DataLayoutCallbackTy (PR #66705)

Jannik Silvanus via llvm-commits llvm-commits at lists.llvm.org
Tue Sep 19 00:03:42 PDT 2023


jasilvanus wrote:

Thanks @nikic.

We rely downstream on the second argument when importing DXIL in order to fix invalid `i8` alignment without using a hardcoded DL string. Instead, we just set natural alignment for `i8` in the passed DL string.

I think it's quite natural to feed the DL string of a module into the callback to allow inspection of the existing string?
Maybe we should document the intended usage and downstream dependency better though, not sure on the policy for such things.



https://github.com/llvm/llvm-project/pull/66705


More information about the llvm-commits mailing list