[PATCH] D156612: [SimplifyCFG] Find the smallest table considering overflow in `switchToLookupTable`

Kohei Asano via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Sep 19 00:00:10 PDT 2023


khei4 added a comment.

I'm still not sure about the correctness of this. It seems like only setting the BeginCaseVal and EndCaseVal to the appropriate values is enough to handle overflowing switch cases. Test transformations themselves look correct!



================
Comment at: llvm/lib/Transforms/Utils/SimplifyCFG.cpp:6439
+  });
+  SmallVectorImpl<ConstantInt *>::iterator CaseValIter = CaseVals.begin();
+  // We start by using the begin and end as the minimal table.
----------------
I think it's ok to use auto on this.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D156612/new/

https://reviews.llvm.org/D156612



More information about the llvm-commits mailing list