[llvm] [Workflow] Add new code format helper. (PR #66684)
Tobias Hieta via llvm-commits
llvm-commits at lists.llvm.org
Mon Sep 18 13:19:43 PDT 2023
tru wrote:
> I really like this, thanks for setting that up! I am a tiny bit concerned about the comments being extra verbose, but I guess we can start that way and adjust as needed.
>
> I'd like @mordante and @philnik777 to take a look in case I'd have missed something but this LGTM for libc++.
>
> A notable behavior change is that we'll now start enforcing that any modified file in `libcxx/test` is `clang-formatted`, but I think that's OK. We could handle that by making our `ignore_format.txt` file contain more entries if needed.
If that's a problem I suggest doing what clang is doing for their tests: https://github.com/llvm/llvm-project/blob/main/clang/test/.clang-format
https://github.com/llvm/llvm-project/pull/66684
More information about the llvm-commits
mailing list