[PATCH] D159524: [BOLT] Speedup symbol table sort

Maksim Panchenko via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Sep 18 11:30:10 PDT 2023


maksfb marked an inline comment as done.
maksfb added inline comments.


================
Comment at: bolt/lib/Rewrite/RewriteInstance.cpp:820
+    if (isSymbolInMemory(Symbol))
+      SortedSymbols.push_back({cantFail(Symbol.getAddress()), Symbol});
+
----------------
jobnoorman wrote:
> `emplace_back`?
Doesn't work with structs.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D159524/new/

https://reviews.llvm.org/D159524



More information about the llvm-commits mailing list