[PATCH] D159520: [BOLT][AArch64] Fix instrumentation deadloop

[Amir Ayupov via Phabricator via llvm-commits]

Amir added inline comments.


================
Comment at: bolt/include/bolt/Core/MCPlusBuilder.h:624
 
+  virtual bool isExclusive(const MCInst &Inst) const {
+    llvm_unreachable("not implemented");
----------------
"Exclusive" is ARM-specific term, so it would help to either clarify it a bit here, or come up with a generic term – maybe "isLoadLockStoreConditionalInst"?


================
Comment at: bolt/lib/Passes/Instrumentation.cpp:297
+  if (BC.isAArch64()) {
+    for (const BinaryBasicBlock &BB : Function)
+      for (const MCInst &Inst : BB)
----------------
Can you please factor out the check into a helper function e.g. `hasExclusiveMemop`?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D159520/new/

https://reviews.llvm.org/D159520