[PATCH] D159357: [AArch64] Move PAuth codegen down the machine pipeline

Anatoly Trosinenko via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Sep 18 08:06:05 PDT 2023


atrosinenko added a comment.

In D159357#4638040 <https://reviews.llvm.org/D159357#4638040>, @vhscampos wrote:

> I don't understand the motivation here. This moves PAuth's instruction insertion later down the pipeline, but why? The handling in the machine outliner isn't made any simpler IMO.

The original motivation was to implement checking the LR value in tail calls (D156716 <https://reviews.llvm.org/D156716>) at some point after both PEI and machine outliner - the outliner doesn't seem to handle checker code well now. It seems that inserting PAuth-related hardening code is generally "the later the better" (IIRC, in the Ahmed's branch it was done even later, at the AsmPrinter phase), so I moved the existing code down the pipeline to handle everything PAuth-related at a single place.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D159357/new/

https://reviews.llvm.org/D159357



More information about the llvm-commits mailing list